Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: increase timeout and skip removing branches #1455

Merged
merged 1 commit into from
Nov 13, 2024
Merged

chore: increase timeout and skip removing branches #1455

merged 1 commit into from
Nov 13, 2024

Conversation

tisutisu
Copy link
Contributor

Description

To help debug the current issue on build-definitions CI, this PR increase the timeout of PR creation to 20 mins and also skip deleting the branches created while running tests

Issue ticket number and link

https://issues.redhat.com/browse/STONEBLD-2981

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

@tisutisu tisutisu requested a review from psturc November 12, 2024 14:10
psturc
psturc approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@psturc psturc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 12, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: psturc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@psturc
Copy link
Member

psturc commented Nov 12, 2024 •
edited
Loading

@tisutisu the e2e test actually failed on this test case

  PipelineRun has not been created yet for Component build-e2e-qekq-tenant/test-symlink-comp-tosf
  [FAILED] in [It] - /tmp/tmp.c6F0z9jQok/tests/build/build_templates.go:178 @ 11/12/24 11:09:48.327
  error while getting pipelineruns: no pipelinerun found for application test-app-vrlh
  error while getting pipelineruns: no pipelinerun found for application test-app-vrlh
  error while getting pipelineruns: no pipelinerun found for application test-app-vrlh
  error while getting pipelineruns: no pipelinerun found for application test-app-vrlh
  error while getting pipelineruns: no pipelinerun found for application test-app-vrlh
  error while getting pipelineruns: no pipelinerun found for application test-app-vrlh
  [FAILED] in [AfterAll] - /tmp/tmp.c6F0z9jQok/tests/build/build_templates.go:276 @ 11/12/24 11:10:48.328
  << Timeline

  [FAILED] Timed out after 1200.000s.
  timed out when waiting for the PipelineRun to start for the Component build-e2e-qekq-tenant/test-symlink-comp-tosf
  Expected success, but got an error:
      <*errors.errorString | 0xc000bf2340>: 
      no pipelinerun found for component test-symlink-comp-tosf
      {
          s: "no pipelinerun found for component test-symlink-comp-tosf",
      }
  In [It] at: /tmp/tmp.c6F0z9jQok/tests/build/build_templates.go:178 @ 11/12/24 11:09:48.327

I think due to this error in build-service

2024-11-12T10:49:47.446Z	ERROR	ComponentOnboarding	controllers/component_build_controller.go:338	Pipelines as Code provision for the Component failed	{"controller": "component", "controllerGroup": "appstudio.redhat.com", "controllerKind": "Component", "Component": {"name":"test-symlink-comp-tosf","namespace":"build-e2e-qekq-tenant"}, "namespace": "build-e2e-qekq-tenant", "name": "test-symlink-comp-tosf", "reconcileID": "83f2da40-c179-4ef1-92ce-5037ee73f903", "ComponentGitSource": {"url":"https://github.com/redhat-appstudio-qe/devfile-sample-python-basic","revision":"base-mzjxfk","context":".","dockerfileUrl":"docker/Dockerfile"}, "error": "admission webhook \"validation.pipelinesascode.tekton.dev\" denied the request: repository already exists with URL: https://github.com/redhat-appstudio-qe/devfile-sample-python-basic"}

@psturc psturc mentioned this pull request Nov 12, 2024
Closed
@psturc
Copy link
Member

psturc commented Nov 13, 2024

/retest

3 similar comments
@psturc
Copy link
Member

psturc commented Nov 13, 2024

/retest

@psturc
Copy link
Member

psturc commented Nov 13, 2024

/retest

@psturc
Copy link
Member

psturc commented Nov 13, 2024

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit db7a5a9 into konflux-ci:main Nov 13, 2024
13 checks passed
@rh-tap-build-team rh-tap-build-team bot mentioned this pull request Nov 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psturc psturc psturc approved these changes

@lcarva lcarva Awaiting requested review from lcarva

@mkosiarc mkosiarc Awaiting requested review from mkosiarc

Assignees

@psturc psturc

Labels
approved lgtm < 1 min
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tisutisu @psturc